389-ds-base

#50750 Ticket 50664 - DS can fail to recover if an empty directory exists in db
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50664-telackey-non-db-files  into  master

Download 50750.patch

Bug Description: In count_dbfiles_in_dir, when the recurse option is set
to false, the counter was zerod. Depending on the opendir (inode, dirent)
ordering of directories in a be folder (ie userRoot), this could cause
an empty directory to be examined last via the recurse option, when then
would clear the counter. If the counter is cleared, the server believes
no db files exist.

Fix Description: Remove the counter-zeroing on recurse == false which
requires us to check the original caller DOES zero the value (I checked,
it does).

https://pagure.io/389-ds-base/issue/50664

Author: William Brown william@blackhats.net.au, Thomas E Lackey telackey@bozemanpass.com

Review by: ???

@telackey - Please note, your patch didn't apply cleanly due to a different backend refactor. That's why I've re-written it, and put your name in the authorship. :)

ACK

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3805

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.