Ack. FYI changes like this don't need a review, you can just push them next time (essentially the one line commit rule).

So, there are still things to fix in these regards. It would be good to have it in one go, I believe.

Have duplicates

800f432a-52ab-4661-ac66-a2bdd9b984d7
9d27f048-7db8-11e8-a71c-8c16451d917b

Empty ID

• 2 cases (grep -Hrni ':id:[\t ]*$')

Inconsistent spacing after :id:

• 88 cases without space (grep -Hrni ':id:[^\t ]' | wc -l)
• 613 cases with space

Non-UUIDs

?3594431f-e681-4a04-8edb-33ad2d9dad5b
552850aa-agc3-473e-9d39-aae812b46f11
800f432a-52ab-4661-ac66-a2bdd9b984d78
800f432a-52ab-4661-ac66-a2bdd9b984d789
800f432a-52ab-4661-ac66-a2bdd9b984d790
ad57de32-1d118-4323-bbca-5556e5cdb786
ad57de32-1d167-4323-bbca-5086e5cdb235
d52a9cw0-3bg6-11e9-9b7b-8c16451d917t

... and pardon the stupid icons, because Pagure thinks preformated literals should have icons, too. :(

Non-UUIDs
?3594431f-e681-4a04-8edb-33ad2d9dad5b
552850aa-agc3-473e-9d39-aae812b46f11
800f432a-52ab-4661-ac66-a2bdd9b984d78
800f432a-52ab-4661-ac66-a2bdd9b984d789
800f432a-52ab-4661-ac66-a2bdd9b984d790
ad57de32-1d118-4323-bbca-5556e5cdb786
ad57de32-1d167-4323-bbca-5086e5cdb235
d52a9cw0-3bg6-11e9-9b7b-8c16451d917t

These are all probably my mistakes. When I added multiple test functions to a file, I would manually modify the ID string. I made sure it was unique, but not that it confirmed to any standard.

Ack. FYI changes like this don't need a review, you can just push them next time (essentially the one line commit rule).

Thank you for trusting me , but I don't trust myself with "one line" commits :) And looks like I missed a few things, for example, in lib389 tests (I wasn't even looking there).

@mhonek, thank you for catching these!

@mhonek, I think I fixed the remaining issues, please review.

Looks good. Thanks!

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3778

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.