Description:
Fix various test issues on RHEL7 and RHEL8:
systemd on RHEL7 doesn't have --value option. Drop --value option and parse the output manually.
Use newer BDB config only on 1.4.2+.
Skip tests/suites/password/pbkdf2_upgrade_plugin_test.py on <1.4.1.
Unhashed passwords are not logged by default only on 1.4.1.6+.
String literal comparison doesn't work with double digits, i.e. '1.3.10.1' > '1.3.2.1' returns False. Use packaging.version to compare versions.
Don't use nsAccount objectClass on versions <=1.4.x.
Update skipif/xfail version to match downstream versions too.
Relates: https://pagure.io/389-ds-base/issue/49761
All looks pretty good to me :) ack
rebased onto 8510fce5ff0a1207041831e184d17474705cb624
rebased onto 15789e895c4b976774dc3cb3ba5e64f23bcd8c3b
Pull-Request has been merged by vashirov
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3757
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Description:
Fix various test issues on RHEL7 and RHEL8:
systemd on RHEL7 doesn't have --value option.
Drop --value option and parse the output manually.
Use newer BDB config only on 1.4.2+.
Skip tests/suites/password/pbkdf2_upgrade_plugin_test.py on <1.4.1.
Unhashed passwords are not logged by default only on 1.4.1.6+.
String literal comparison doesn't work with double digits,
i.e. '1.3.10.1' > '1.3.2.1' returns False.
Use packaging.version to compare versions.
Don't use nsAccount objectClass on versions <=1.4.x.
Update skipif/xfail version to match downstream versions too.
Relates: https://pagure.io/389-ds-base/issue/49761