389-ds-base

#50695 Issue 50572 - After running cl-dump dbdir/cldb/*ldif.done are not deleted
Closed by spichugi. Opened by sgouvern.
sgouvern/389-ds-base ticket_50572  into  master

Download 50695.patch

Description:
Includes an automated test to verify the cl-dump legacy tool behavior regarding the generated files:
By default, ldif.done files are removed after running cl-dump.
An option '-l' allows to keep the files.

Includes too an automated test to check that the dsconf dump-changelog counterpart of the legacy   
cl-dump perl script works the same way
Fixes https://pagure.io/389-ds-base/issue/50572
Relates : https://pagure.io/389-ds-base/pull-request/50573
Review by: ??

Are these commented lines here on purpose?

I think it is possible to encapsulate most of the code.
If I understood correctly, only the command is changed between the test functions.

Not all commented lines are on purpose :( Only those linked to the cl-dump.pl exit code which will have to be modified when the bug fixed.
I'll remove the unexpected ones.
And surely some parts could be encapsulated. I'll have a look.
Thanks.

Maybe you can even parametrize these functions into one. But it's up to you, I think :)

rebased onto eaba7271aa05572a0de3c11608dbe67688b106bb

Extra commented lines has been removed.
skipif has been fixed now that version comparison works correctly.
ldif files removing has been encapsulated, the rest has been kept as is for a better reading of these tests.
Thanks to review !

Thanks! Looks great!
Ack

rebased onto 225b826c3e9d6e5c1875c350bec0d61633f1ea00

spichugi, thanks !
Viktor, I've just realized that we should have test_cldump_files_removed xfailed rather than failed, on older versions than 1.3.10.1. So I added a 'xfail' mark. Could you please review and merge if ok for you ? Thanks

LGTM! Please fixup commits into one and I'll merge it.

rebased onto aa11792dc9294bab1696340d8284178424dfc4c8

Viktor, done. Thanks!

rebased onto 51e2c4581e8640f22f563ae3c7c99b4e670992e0

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3750

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.