#50692 Issue 50536 - After audit log file is rotated, DS version string is logged after each update
Closed by spichugi. Opened by bsmejkal.
bsmejkal/389-ds-base rotate_audit_log  into  master

Download 50692.patch

Description:
Created test case, which checks if DS version string is present only once
at the top of the audit log after it is rotated.

Relates: https://pagure.io/389-ds-base/issue/50536

Reviewed by: ???

I think it's better to reuse the existing user instead of getting the first one. It may be that the wrong user will be returned.

You can just assign the returned object on the create() method: user = users.create(properties={

I think it's important to set the changed configuration back at the end of the test case. Other tests may rely on it.

rebased onto da4f5801f177a0145db55cb4f190906328b76f9a

@spichugi
Changes done as per suggestion.
I created a function that sets the audit log configuration and then resets it back to default values. It is also modified to be usable for the future tests.
Please review.

Great! Looks good to me! Ack

rebased onto fb3d355933335af85b1c8491eb5a67e67b7c32e9

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3747

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata