389-ds-base

#50670 Ticket 50669 - remove nunc-stans
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50669-remove-nunc-stans  into  master

Download 50670.patch

Bug Description: We have been attempting to modernise our
connection code for a long time - one attempt was nunc-stans.
However after a series of attempts to integrate it, and multiple
failures we discussed this in the listed email thread and decided
to remove this.

https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/thread/3JRQQRIPOVDLLRD2QMF2PWNHJGZFUDCC/

Fix Description: rm -r src/nunc-stans

https://pagure.io/389-ds-base/issue/50669

Author: William Brown william@blackhats.net.au

Review by: ???

We still have the configuration setting in libglobs.c It could be present in someone's dse.ldif, so we need to handle it and ignore it, maybe log a message that it's been abandoned?

I didn't remove the config option, if present it's ignored because nothing in the server reads it.

Logging taht we ignore it is a good idea though.

Updated with log message:

[25/Oct/2019:09:56:22.773067400 +1000] - WARN - slapd_daemon - cn=config: nsslapd-enable-nunc-stans is on. nunc-stans has been deprecated and this flag is now ignored.
[25/Oct/2019:09:56:22.778913200 +1000] - WARN - slapd_daemon - cn=config: nsslapd-enable-nunc-stans should be set to off or deleted from cn=config.
[25/Oct/2019:09:56:22.789553700 +1000] - INFO - slapd_daemon - slapd started.  Listening on All Interfaces port 3389 for LDAP requests

rebased onto f006e991790bf93de7519f30c4935a4aada8b502

LGTM

rebased onto 44e92dc8b900efda68f3ce5c8ecb1a7fbe80a6ee

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3725

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.