PR#50663: Issue 50634 - Clean up CLI errors output - Fix wrong exception - 389-ds-base

389-ds-base

#50663 Issue 50634 - Clean up CLI errors output - Fix wrong exception

Closed 3 years ago by spichugi. Opened 4 years ago by spichugi.

spichugi/389-ds-base fix-exception-log-cleanup into master

Issue 50634 - Clean up CLI errors output - Fix wrong exception

Simon Pichugin • 4 years ago

abc6f16

src/lib389/lib389/cli_base/__init__.py

file modified

+1 -1

		`@@ -423,6 +423,6 @@`
		`errmsg = str(exception)`
		`try:`
		`msg = ast.literal_eval(errmsg)`
		`- except ValueError:`
		`+ except Exception:`
		`msg = {'desc': errmsg}`
		`return msg`

spichugi commented 4 years ago

Description: The previous commit takes care only about ValueError
evaluation. But it is possible that other exceptions will be raised
which will result in a wrong error output.
Make the exception object more general.

https://pagure.io/389-ds-base/issue/50634

Reviewed by: ?

spichugi commented 4 years ago

Thank you, @mhonek , for the fast reporting!