#50650 Issue 50646 - Improve task handling during shutdowns
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50646  into  389-ds-base-1.4.1

Download 50650.patch

Bug Description:

There is a race condition when stopping the server and a running import task that can cause a heap-use-after-free.

Fix Description:

For an import task, encapsulate the import thread with a global thread increment/decrement (just like the export task). Also improved how tasks are notified to abort by notifying them before we wait for active threads to finish. Then the tasks get destroyed after all threads are complete.

relates: https://pagure.io/389-ds-base/issue/50646

this is now in db-bdb/bdb_inmport.c.

do you prepare another version on master ?

this is now in db-bdb/bdb_inmport.c.
do you prepare another version on master ?

I will, but this needs to get into 1.3.10 first, so I started at 1.4.1 branch, and will front port it to master once ack'ed.

this is now in db-bdb/bdb_inmport.c.
do you prepare another version on master ?

I will, but this needs to get into 1.3.10 first, so I started at 1.4.1 branch, and will front port it to master once ack'ed.

ok, ack

You also have my ACK

rebased onto 467314880104ceef5e233f6c0154fa7dfd993a17

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3705

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata