PR#50643: Ticket 50627 - Support platforms without pytest_html - 389-ds-base

389-ds-base

#50643 Ticket 50627 - Support platforms without pytest_html

Closed 3 years ago by spichugi. Opened 4 years ago by firstyear.

firstyear/389-ds-base 20191010-asan-conftest into master

Ticket 50627 - Support platforms without pytest_html

William Brown • 4 years ago

6377bc7

dirsrvtests/conftest.py

file modified

+1 -1

		`@@ -94,7 +94,7 @@`
		`outcome = yield`
		`report = outcome.get_result()`
		`extra = getattr(report, 'extra', [])`
		`- if report.when == 'call':`
		`+ if report.when == 'call' and pytest_html is not None:`
		`for f in glob.glob(f'{p.run_dir}/ns-slapd-san'):`
		`with open(f) as asan_report:`
		`text = asan_report.read()`

firstyear commented 4 years ago

Bug Description: On systems without pytest_html the conftest
hook would cause tests to fail

Fix Description: If pytest_html is none, don't write the report
to avoid the failure.

https://pagure.io/389-ds-base/issue/50627

Author: William Brown william@blackhats.net.au

Review by: ???

vashirov commented 4 years ago

Please add 'Fixes' keyword before the url in the commit message (pagure will auto close the issue automatically for you! Less admin overhead). The rest looks good, ack.

firstyear commented 4 years ago

Lets try this magic computer shenanginas with Fixes: URL then :D

Thanks for your patience and advice as always @vashirov

rebased onto 6377bc7

4 years ago

Pull-Request has been merged by firstyear

4 years ago