PR#50598: Ticket 50593 Investigate URP handling on standalone instance - 389-ds-base

389-ds-base

#50598 Ticket 50593 Investigate URP handling on standalone instance

Closed 3 years ago by spichugi. Opened 4 years ago by lkrispen.

lkrispen/389-ds-base t50593 into master

Ticket 50593 Investigate URP handling on standalone instance

Ludwig Krispenz • 4 years ago

0caae8a

ldap/servers/plugins/replication/repl5_plugins.c

file modified

		`@@ -575,6 +575,10 @@`
		`{`
		`int rc= SLAPI_PLUGIN_SUCCESS;`

		`+ if (!is_mmr_replica(pb)) {`
		`+ return rc;`
		`+ }`
		`+`
		`switch (flags)`
		`{`
		`case SLAPI_PLUGIN_BE_PRE_ADD_FN:`
		`@@ -598,6 +602,10 @@`
		`{`
		`int rc= SLAPI_PLUGIN_SUCCESS;`

		`+ if (!is_mmr_replica(pb)) {`
		`+ return rc;`
		`+ }`
		`+`
		`switch (flags)`
		`{`
		`case SLAPI_PLUGIN_BE_TXN_POST_ADD_FN:`

lkrispen commented 4 years ago

Bug: If the MMR plugin is enabled (on by default)
even if no replica was configured the MMR plugins were called
and eventually tried to generate cenotaphs for modrdn ops-

Fix: Check early if the operation affects a backend without replication
and return

tbordaz commented 4 years ago

The patch looks good. ACK

But I am missing something.
Does that mean that without that patch, any write operation on a standalone server was calling urp and write_changelog_and_ruv ?

lkrispen commented 4 years ago

I think so, but there are more checks for is_mmr_replica and I don't think it would have tried to write the changelog, for urp I think it only tried to do something since the conflict changes.

I hope we are safe now

rebased onto 0caae8a

4 years ago

Pull-Request has been merged by lkrispen

4 years ago