PR#50591: Do not use comparision with "is" for empty value - 389-ds-base

389-ds-base

#50591 Do not use comparision with "is" for empty value

Closed 3 years ago by spichugi. Opened 4 years ago by tdudlak.

tdudlak/389-ds-base rawhide-comparision into master

Do not use comparision with "is" for empty value

Tibor Dudlák • 4 years ago

d0c846b

src/lib389/lib389/dirsrv_log.py

file modified

+1 -1

		`@@ -145,7 +145,7 @@`
		`TZ=timedata['tz'],`
		`)`
		`dt = dt_parse(dt_str)`
		`- if timedata['nanosecond'] is not '':`
		`+ if timedata['nanosecond']:`
		`dt = dt.replace(microsecond=int(int(timedata['nanosecond']) / 1000))`
		`return dt`

tdudlak commented 4 years ago

There is a warning with python 3.8 at fedora rawhide about
comparision with "is" while running ipa-server install:
dirsrv_log.py:148: SyntaxWarning: "is not" with a literal. Did you mean "!="
Removing "is not ''" as this should not be needed
to make sure that timedata['nanosecond'] is empty.

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

tdudlak commented 4 years ago

  [1/44]: creating directory server instance

Starting installation...
/usr/lib/python3.8/site-packages/lib389/dirsrv_log.py:148: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if timedata['nanosecond'] is not '':
Created symlink /etc/systemd/system/multi-user.target.wants/dirsrv@EXAMPLE-TEST.service → /usr/lib/systemd/system/dirsrv@.service.

Edited 4 years ago by tdudlak