389-ds-base

#50573 Issue 50572 - After running cl-dump dbdir/cldb/*ldif.done are not deleted
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base cl-dump-fix  into  master

Download 50573.patch

Description: By default, remove ldif.done files after running cl-dump.
Add an option '-l' which allows keep the files.
Modify 'dsconf replication dump-changelog' command accordingly.
Update man files.

https://pagure.io/389-ds-base/issue/50572

Reviewed by: ?

rebased onto 2123d9f33e1cdcc90d58570510e117e63dc647f9

Never use negatives in options, because this confuses the logic. It should be "remove_ldif_done=True" and then the override is to set false. IIRC this is in the style guide :)

Nack, this has to be a positive option IE "preserve-cl-ldif". Don't have negatives in cli options,

rebased onto ba2bfea1c35a2767f7d145782c0270e7c0d37f2f

Nack, this has to be a positive option IE "preserve-cl-ldif". Don't have negatives in cli options,

Right, missed that. Thank you! Fixed

Indentation is code in this code block sequence :-)

LGTM besides that one minor comment

Ack from me too.

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3629

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.