389-ds-base

#50569 Issue 49324 - idl_new fix assert
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base fix-assert  into  master

Download 50569.patch

Description: Remove faulty assert, and retrieve best effort name of index

relates: https://pagure.io/389-ds-base/issue/49324

rebased onto 95117b061d089670463de650f4e41e9c6086c203

The fix looks good. ACK

a minor comment, should not we check db->fname != NULL.

The fix looks good. ACK
a minor comment, should not we check db->fname != NULL.

I think you have to have an index file to even be in this function, but I will add another check...

rebased onto 8474a1721b3f6f5bc297138e3a839fe44e5b0adf

Pull-Request has been merged by mreynolds

Just move the PR_ASSERT here to check index_id != NULL now.

Just move the PR_ASSERT here to check index_id != NULL now.

It's impossible for it to be NULL with this code change...

Sorry, your right, I clearly didn't read it properly :) all good!

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3625

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.