the old code definitely looks wrong and your fix looks good, I cannot tell if this will fix the cache corruption, but I think it is likely.

So ack to commit this patch

the old code definitely looks wrong and your fix looks good, I cannot tell if this will fix the cache corruption, but I think it is likely.

Well what happens is that the operation is reported as success and if you search for the new entry you find it. But the database was never updated. If you restart the server you will see the update was not applied. So basically the cache should not have been updated, but by fixing the variable everything works as expected. If you try to update the phantom entry weird things happen - typically an error 1.

thanks, ack

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3612

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.