Bug Description: Investigate and port TET matching rules filter tests(match more test cases)
Relates/Fixes: https://pagure.io/389-ds-base/issue/48851
Author: aborah
Reviewed by: ???
rebased onto c0019c77f839187b566331af596ede39a099789a
The same issue as here - https://pagure.io/389-ds-base/pull-request/50540#comment-97761
The docstring doesn't describe what you actually test (match count). The same is with other docstrings in the file (could you please extend them?)
This one is different ,
for attr, value in LIST_ATTR: cos.create(properties={ 'cn': attr, 'attr' + attr.split('entry')[1][:-1]: value })
say,
attr = "entryoctetStringMatch0" and value = "AAAAAAAAAAAAAAE=" cos.create(properties={ 'cn': "entryoctetStringMatch0", 'attroctetStringMatch": "AAAAAAAAAAAAAAE=" })
Here i am creating "attroctetStringMatch" from 'attr' + attr.split('entry')[1][:-1]
I need "attroctetStringMatch" attribute in the created entry , other wise test will fail .
Please refer original TET filter test cases for more clarification.
1 new commit added
Fixing Simon's comments .
Replied
Done
The code looks good
2 new commits added
Issue: 48851 - investigate and port TET matching rules filter tests(match more test cases)
Issue: 48851 - Investigate and port TET matching rules filter tests(match more test cases)
rebased onto f1b80588b22fee7e646f891ced44218d45138865
rebased onto 040400386625e85e2f7b636f16e43c1069f51349
rebased onto 166a594c0e130e5e2a74e681dbe5dcbb1625913b
Pull-Request has been merged by vashirov
Thank you, Anuj! Merged.
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3597
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description: Investigate and port TET matching rules filter tests(match more test cases)
Relates/Fixes: https://pagure.io/389-ds-base/issue/48851
Author: aborah
Reviewed by: ???