DSLdapObjects.create() function returns DSLdapObject instance. So why not reuse it later in the code? It will be a huge cleanup.

Why do you use mode['attr'].split('attr')[1] instead of mode['attr'] where mode['attr'] = 'attribute_name_without_attr_prefix'?
It'll make much more sense to just add attr prefix when needed.

Also, I just noticed, you named the test suite without _test suffix. So it is not discoverable by py.test automatically.

Please, rename it. Also, you already have filter_match_test.py. So maybe filter_index_match_test.py?

And please, if you use something more then once and it is a complex expression (some operation) - remember to assign it to a variable. And then reuse the variable.
It increases readability.

DSLdapObjects.create() function returns DSLdapObject instance. So why not reuse it later in the code? It will be a huge cleanup.

Done

Why do you use mode['attr'].split('attr')[1] instead of mode['attr'] where mode['attr'] = 'attribute_name_without_attr_prefix'?
It'll make much more sense to just add attr prefix when needed.

Done

Also, I just noticed, you named the test suite without _test suffix. So it is not discoverable by py.test automatically.
Please, rename it. Also, you already have filter_match_test.py. So maybe filter_index_match_test.py?

Done

And please, if you use something more then once and it is a complex expression (some operation) - remember to assign it to a variable. And then reuse the variable.
It increases readability.

Done

LGTM! Ack

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3596

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.