389-ds-base

#50527 Issue: 48055 - CI test-(Plugin configuration should throw proper error messages if not configured properly)
Closed by spichugi. Opened by aborah.
aborah/389-ds-base bz834056  into  master

Download 50527.patch

CI test-(Plugin configuration should throw proper error messages if not configured properly)

Relates: https://pagure.io/389-ds-base/issue/48055

Author: aborah

Reviewed by: ???

rebased onto 5e789a8ecdda824fefcabdf55d2d2945ad525d75

rebased onto 48a040dae891931d7e88daa4f1022c54108a5eeb

rebased onto 8b1ba638eb74827c825c0c4dac35424504682ffb

rebased onto b5c41a969542cf0990a5bb081df2a71bf6326556

Extra line

It is already included in AutoMembershipPlugin

There is no description

it is also about mixing the suffixes for autoMemberDefaultGroup

What do you need replication for? Why not use 'standalone'?

Please, use lib389/dirsrv_log.
We will deprecate searchErrorsLog soon

Please, use lib389/dirsrv_log.
We will deprecate searchErrorsLog soon

(Pdb) dirlog1 = DirsrvLog(topo.standalone)
(Pdb) DirsrvErrorLog(dirlog1)

(Pdb) DirsrvErrorLog(dirlog1).parse_line('ERR - auto-membership-plugin')
*** AttributeError: 'NoneType' object has no attribute 'groupdict'

Looks like lib389/dirsrv_log. does not work properly

Edited by aborah

(Pdb) dirlog1 = DirsrvLog(topo.standalone)
(Pdb) DirsrvErrorLog(dirlog1)

I am not sure what you are doing here...

Try to search for the examples in our code (basically lib389/dirsrv_log is used only for creating an alias in DirSrv() object)

And you can use these aliases to perform tasks (once again, you can find a lot of examples through the code).
Edited by spichugi

1 new commit added

  • finxing simon's comments

@spichugi changes are done as your suggestion

The test module name still has the bz number in it dirsrvtests/tests/suites/automember_plugin/bz834056_test.py ...

test_mmr_setup_mixed_the_plugin_configuration can be misinterpreted...
Like mmr_setup mixed the_plugin_configuration...

rebased onto 5a35ff13baae89d6221d26279bb2e304a8cc46d5

The test module name still has the bz number in it dirsrvtests/tests/suites/automember_plugin/bz834056_test.py ...
test_mmr_setup_mixed_the_plugin_configuration can be misinterpreted...
Like mmr_setup mixed the_plugin_configuration...

renamed test case and module name.

automembership_plugin is already in the test dir name.
So I think it can be removed from the module name and from the test case name.

rebased onto ca7b405aa9af7011ac089e4bd8c410c3c1b7a21e

rebased onto 46639d5190ee93f7457e4dc3afdaaf80a170c0c8

automembership_plugin is already in the test dir name.
So I think it can be removed from the module name and from the test case name.

renamed both (module and test case )

LGTM. Ack

rebased onto 723b88a27b5d3af7cd2c23d32b2e6ea1df539f8e

Pull-Request has been merged by vashirov

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3583

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.