#50505 Issue 50355 - SSL version min and max not correctly applied
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base issue50355  into  master

Download 50505.patch

Bug Description: Setting the sslVersionMin or SSLVersionMax was not
correctly applied and the NSS default min and max
became the valid range.

Fix Description: Do not attempt to reset the requested range based off
of hardcoded limits. Also removed obsolete SSL3 code,
and fixed a minor memory leak in main.c found during
ASAN testing.

Relates: https://pagure.io/389-ds-base/issue/50355

ASAN approved

The comment is now useless

If a dse.dlif contain "ssl3" it will log "The value of sslVersion{min/max} is invalid..."
It is not invalid but no longer supported. We may also keep this block to report a more precise message.

Minor comments, the patch looks good to me. ACK

rebased onto 57b990de0d863a2ac0942b618bde97cc0a84e6b8

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3561

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata