389-ds-base

#50482 Issue: 48851 - investigate and port TET matching rules filter tests(indexing final)
Closed by spichugi. Opened by aborah.
aborah/389-ds-base index_final  into  master

Download 50482.patch

Bug Description: Investigate and port TET matching rules filter tests(indexing final)

Relates : https://pagure.io/389-ds-base/issue/48851

Author: aborah

Reviewed by: ???

rebased onto 6fa96e0c9ba724a1b0f192d0ccbff83366625757

rebased onto 22d5f175040f6d2d3fa49a6b82fc67b25e2699a3

rebased onto bf0bc8013196fc75be3746da3d77a1a41f6ab0bb

Test case module name has a typo
Edited by spichugi

It looks more like a fixture to me. Other tests depend on it if I understand correctly.
Also, I see no reason for create_index encapsulation...

Specify the type of exception it's expected to fail with.

It is not unique

1 new commit added

  • Fixing Simon's comments

It looks more like a fixture to me. Other tests depend on it if I understand correctly.
Also, I see no reason for create_index encapsulation...

It is a test case other test does not depend on it , i have removed the create_index encapsulation

@spichugi , other changes are also done

It is a test case other test does not depend on it , i have removed the create_index encapsulation

Okay... Then how other two test cases relate to indexing? And how is it different from what you do in filter_match_test.py?

1 new commit added

  • Fixing Simon's comments 2

It is a test case other test does not depend on it , i have removed the create_index encapsulation

Okay... Then how other two test cases relate to indexing? And how is it different from what you do in filter_match_test.py?

Yes , it should a fixture module , we have to create the indexes before running any test case . I have made the test case a fixture and called it before running any test function

LGTM

rebased onto 4d2442cfa66540332b319fdd46089bf754c09526

rebased onto 120bee6ba252edc12243daa38d5c47b3611b41ef

Test case module name has a typo

Still present

rebased onto 5ee2ebf8222542dbf805b450f13da2a299b6e855

Test case module name has a typo

Still present

corrected

corrected

Weird... Pagure still shows me filter_index_matchig_rule.py

rebased onto 7fb2595757a85fed45b42826a1c21e1e9827f224

corrected

Weird... Pagure still shows me filter_index_matchig_rule.py

Sorry i pushed old file , now its correct

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3539

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.