PR#50458: Ticket 50439 - fix waitpid issue when pid does not exist - 389-ds-base

William Brown • 4 years ago

f874c39

src/lib389/lib389/__init__.py

file modified

+4 -1

		`@@ -213,7 +213,10 @@`
		`else:`
		`raise`
		`# Tell the OS to reap this please ...`
		`- os.waitpid(pid, os.WNOHANG)`
		`+ try:`
		`+ os.waitpid(pid, os.WNOHANG)`
		`+ except ChildProcessError:`
		`+ pass`
		`return True`

		`def pid_from_file(pidfile):`

Bug Description: In some situations, waitpid will fail with
a no child process error, when the pid file has a value but
no pid exists.

Fix Description: Catch the exception, because in this case
we have no pids to wait upon, so there is no harm to skip this.

Review by: ???

LGTM

Pull-Request has been merged by firstyear

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3516

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago

Assignee

None

Tags

No Tags