Bug Description: Investigate and port TET matching rules filter tests(more testcase to match)
Relates: https://pagure.io/389-ds-base/issue/48851
Author: aborah
Reviewed by: ???
I think it will be hard to modify in the future because it is really hard to follow. It will be better if you'll define a list of dicts and iterate through them in the parametrized test function. Something like this:
[{'cn': value1, 'attr': value1, 'positive': value1, 'negative': value1}, {'cn': value2, 'attr': value2, 'positive': value2, 'negative': value2}, ...]
Also, please, change the commit message to something like this: https://pagure.io/389-ds-base/c/7596ca048c14d4ebcdd77454aa15f272b30482a5?branch=master
1 new commit added
Issue: 48851 - Add more testcase to match test suit.
@spichugi changes are done as per your suggestion
Small nitpick but I think it can be a good improvement. Could you please construct cn out of attr name? It follows the same pattern so it's kind of redundant now.
cn
attr
Fixing Simon's comments 2
Could you please also modify test_valid_invalid_attributes the same way? Also test_valid_invalid_modes and test_valid_invalid_attributes have the same docstring.
test_valid_invalid_attributes
test_valid_invalid_modes
Fixing Simon's comments 3
LGTM
rebased onto 602ceaceac2a4f956665ea30dd64bff05718c5db
rebased onto a1beedfb8b80c511fff8d103bdb0a296349bf48a
Please, fix the grammar in Commit message.
Add more test cases to the match test suite
@spichugi done
rebased onto 0e67cfaabdc60eddced9f3206e3e1e8b3d89f624
Something went wrong
rebased onto 1924c12b234fe21bf37851ef6a0e5351b71183d8
@spichugi Fixed
Pull-Request has been merged by spichugi
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This pull request has been cloned to Github as issue and is available here: - https://github.com/389ds/389-ds-base/issues/3509
If you want to continue to work on the PR, please navigate to the github issue, download the patch from the attachments and file a new pull request.
Thank you for understanding. We apologize for all inconvenience.
Pull-Request has been closed by spichugi
Bug Description: Investigate and port TET matching rules filter tests(more testcase to match)
Relates: https://pagure.io/389-ds-base/issue/48851
Author: aborah
Reviewed by: ???