#50444 Ticket 50037 - revert path changes as it breaks prefix/rpm builds
Closed 3 years ago by spichugi. Opened 4 years ago by firstyear.
firstyear/389-ds-base 50037-revert-path-change  into  master

file modified
+2 -2
@@ -58,14 +58,14 @@ 

  

      # find lib389/clitools -name ds\* -exec echo \''{}'\', \;

      data_files=[

-         ('sbin/', [

+         ('/usr/sbin/', [

              'cli/dsctl',

              'cli/dsconf',

              'cli/dscreate',

              'cli/dsidm',

              'cli/dscontainer',

              ]),

-         ('share/man/man8', [

+         ('/usr/share/man/man8', [

              'man/dsctl.8',

              'man/dsconf.8',

              'man/dscreate.8',

Bug Description: A change was made to support virtual envs, but it
causes a regression that breaks prefix building to access the cli
tools.

Fix Description: Revert the path changes - the other patch changes
were tottaly reasonable, and can remain.

https://pagure.io/389-ds-base/issue/50037

Author: William Brown william@blackhats.net.au

Review by: ???

Please change the commit message to have a word "Related" before the url to the issue. This will create an automatic back link to the issue and post the relevant commit id there.

You have my ack.

Like this? Or a different format? (Can we use #XXXXX syntax instead maybe?)

Related: https://pagure.io/389-ds-base/issue/50037

Yes, like this. Here's the full description of this pagure feature (hidden in Settings -> Hooks -> Pagure):

Pagure specific hook to add a comment to issues or pull requests if the pushed
commits fix them
or relate to them. This is determined based on the commit message.

To reference an issue/PR you need to use one of recognized keywords followed by
a reference to the issue or PR, separated by whitespace and and optional colon.
Such references can be either:

The issue/PR number preceded by the # symbol
The full URL of the issue or PR
If using the full URL, it is possible to reference issues in other projects.

The recognized keywords are:

fix/fixed/fixes
relate/related/relates
merge/merges/merged
close/closes/closed
Examples:

Fixes #21
related: https://pagure.io/myproject/issue/32
this commit merges #74
Merged: https://pagure.io/myproject/pull-request/74
Capitalization does not matter; neither does the colon between keyword and
number.

I personally prefer full links because I often access related issues from git log and a full link saves a few key presses.

rebased onto a5e20b8fcf9e6706b6358580c6649fcdc6ffe76e

4 years ago

rebased onto 09ba251

4 years ago

Pull-Request has been merged by firstyear

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3502

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata