#50437 Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)
Closed by spichugi. Opened by aborah.
aborah/389-ds-base bug77  into  master

Download 50437.patch

Investigate and port TET matching rules filter tests(bug772777)

Relates: https://pagure.io/389-ds-base/issue/48851

Author: aborah

Reviewed by: ???

There's no need for this function. Just put the people.create(...) call into the fixture below directly.

Please, don't split the very long strings like this. In tests, it is better to have an easily followable content rather than strictly following 80-chars-per-line rule. It took me quite some time even to find out how many elements this list has. Just make the filters a single string, it will get much more readable.

I have no idea what this line wants to tell...

1 new commit added

  • Fixing Matus Honek's comments

2 new commits added

  • Fixing Matus Honek's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)

@mhonek changes are done as per your suggestion

2 new commits added

  • Fixing Matus Honek's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)

I think you don't need it here at all. It is not used by the test case in any way. It can be hardcoded.

Okay, I see what Matus was telling about. I think we can improve it even better because now it is not readable.
You can chop down the string in (manager=) parts. Or you can use join function and generate the string out of the list

== 3 is true now but can be changed in the future.
It will be cleaner if you'll create a fresh suffix for the test case.

This step is not mentioned in the docstring

1 new commit added

  • Fixing Simon's comments

3 new commits added

  • Fixing Simon's comments
  • Fixing Matus Honek's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)

@spichugi changes are done as per your suggestion

3 new commits added

  • Fixing Simon's comments
  • Fixing Matus Honek's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)

3 new commits added

  • Fixing Simon's comments
  • Fixing Matus Honek's comments
  • Issue: 48851 - investigate and port TET matching rules filter tests(bug772777)

It is really inconsistent...
Sometimes you have = in the end, sometimes in the begining, sometimes the whole (manager=uid=cnewport, dc=anuj, dc=com) is in the line, sometimes not.

Why did you remove the previous steps with the user bind? I think it makes sense to test

Why did you remove the previous steps with the user bind? I think it makes sense to test

I need to set ACI there to give permission as its a new backend .

I see no reason why not to do this.

1 new commit added

  • Fixing Simon's Comments 2

@spichugi changes are done as per your suggestion

Don't forget to run pylint. You have a trailing whitespace here.

Still, it should e more steps here according to your actual code...

You already have the pytest mark.
I see no reason to name the test module dirsrvtests/tests/suites/filter/filter_bug772777_test.py.
I think you can make it a part of basic filter test suite or name it according to the actual content.

1 new commit added

  • Fixning Simon's commnets 3

@spichugi changes are done as per your suggestion

rebased onto 195ccf209984aa6a0aacbf1c706b01b65ed3fdd1

rebased onto 5fb5537d3ba446b35e0291fc43087db7e2cc0cf9

rebased onto d2566580a8ab847d5e5190faabe252feadb79978

rebased onto 22bc4bf73a6986e8747e2ae21901dddf982d84af

rebased onto 86077ec5be85201b9dcf8ec7048300dacc971fb1

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3495

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata