Please, make this a list. There's no reason to have it as a string and then split it on spaces.

What is the reason for not using this (the Schema.get_matchingrules) below? I believe it's obnoxious to do the magic below on top of actual attr's value.

Please, rather use named parameters than subscripting a single variable here. It makes the code harder to read.

One 'test' word here's redundant.

What is the reason for not using this (the Schema.get_matchingrules) below? I believe it's obnoxious to do the magic below on top of actual attr's value.

I have fixed it . But i must say

 for i in Schema(topology_st.standalone).get_matchingrules(): i.names

does not return clean names . it return something like

('caseExactMatch',)
('caseExactOrderingMatch',)
('caseExactOrderingMatch-en',)
('caseExactSubstringMatch-en',)
('caseExactSubstringsMatch',)

why the comma is coming along with names . It should be some thing like this
('caseExactMatch')
('caseExactOrderingMatch')
('caseExactOrderingMatch-en')
('caseExactSubstringMatch-en')
('caseExactSubstringsMatch')

Is it some kind of bug .

@mhonek changes are done as per your suggestion

Is it some kind of bug .

It's not a bug, it's how Python deals with parens as in grouping vs. parens as in tuple definition. (https://wiki.python.org/moin/TupleSyntax)

Try to call type on both syntaxes and see for yourself. :)

The changes LGTM (but only look as I cannot git fetch them currently, thanks pagure...). Thanks!

I'll let others have a look, as well, before merging.

Should be two steps. And fix formatting please

Please, name the test according to what it does. You test matching rules in other test suites too. Also, please, name it with word "matching_rules" or something. "match" has a different meaning

This line should describe what is the test is about.

Test the matching rules feature

Please, assign Schema(topology_st.standalone).get_matchingrules() to some variable. I see no reason to execute it two times...

Try to avoid names like data. It is not descriptive at all. Name exactly the thing you iterate through

@spichugi changes are done as per your suggestion

Please, name the test according to what it does. You test matching rules in other test suites too. Also, please, name it with word "matching_rules" or something. "match" has a different meaning

Please, name the test according to what it does. You test matching rules in other test suites too.

Please, assign Schema(topology_st.standalone).get_matchingrules() to some variable. I see no reason to execute it two times...

Please, name it accordingly to its content. You are doing get_matchingrules

Try to avoid names like data. It is not descriptive at all. Name exactly the thing you iterate through

You have issues like this in another place of the test suite.

Should be two steps

@spichugi changes are done as per your suggestion

Why did you change the UUID here?
Also, Please, don't break the UUID format. It should be 16-base and have a certain amount of characters
https://en.wikipedia.org/wiki/Universally_unique_identifier

Ok, I see, we had a miscommunication here.
Please, use only one verb in imperative mood per step. Otherwise, it creates a confusion.

So now I see, it should be three steps in this test case because you have three code instructions:
1. create
2. delete
3. create

1. pass
2. pass
3. fail

@spichugi changes are done as per your suggestion

LGTM.

P.S. for the better communication and better understanding, please, answer the questions, don't ignore them... I am really would like to understand your way of thought and it is the reason I ask questions. :)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3491

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.