I have a doubt here. with legacy tools removed instances have a .removed directory. But in case of create/remove/recreate I think we have both slapd-foo and slapd-foo.removed directories. In such case testing .removed directory may be not sufficient

I have a doubt here. with legacy tools removed instances have a .removed directory. But in case of create/remove/recreate I think we have both slapd-foo and slapd-foo.removed directories. In such case testing .removed directory may be not sufficient

I am not sure that I am getting your concern...
I've just tested the PR and it works fine when we have both slapd-foo and slapd-foo.removed.
It filters out slapd-foo.removed and uses slapd-foo only.

The PR looks good to me!

I have a doubt here. with legacy tools removed instances have a .removed directory. But in case of create/remove/recreate I think we have both slapd-foo and slapd-foo.removed directories. In such case testing .removed directory may be not sufficient

Isn't this function just to prevent the slapd.foo.removed from being listed as a valid instance?

I have a doubt here. with legacy tools removed instances have a .removed directory. But in case of create/remove/recreate I think we have both slapd-foo and slapd-foo.removed directories. In such case testing .removed directory may be not sufficient

As others have mentioned this code is just filtering out "*.removed" instances, otherwise they would be listed as valid instances (which is bad)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3480

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.