#50421 Issue: 48851 - Add more search filters to vfilter_simple test suite
Closed by spichugi. Opened by aborah.
aborah/389-ds-base final  into  master

Download 50421.patch

Add more search filters to vfilter_simple test suite

Fixes: https://pagure.io/389-ds-base/issue/48851

Author: aborah

Reviewed by: ???

rebased onto 708eb1a851843082d105bb23848a09296025ccb7

Okay, now after you've put all of the test cases I see the pattern.
You have a lot of code repetition across vfilter_* files.

I think it makes sense to put all of the test cases into one file because the topology (non_english_user, english_named_user, user_with_postal_code, _create_test_entries) is redundant across all of the test files and it basically takes at least 50% of the test suite lines.

You can resolve the redundancy with any way you like but the topology should not be repeated...

rebased onto dc55a5d5ceb8dfde149eace7b298e744bd5f3f32

rebased onto faf84d2c8189adafe32e6817eb74730354e84fa7

rebased onto b379a3429a585b40cd22e6372b7a6cf6b7c1457b

@spichugi all three script has been combined

Please, change the PR name, commit message header and body according to the content.

rebased onto 5198f76c3c5d109225a9c133c5096f6c1b963d35

@spichugi Done

Hmm, you already have the original commit with the same name.
Probably, should be something like Add more search filters to vfilter_simple test suite.

rebased onto ad2771e4190cebe52baebe59e2c15237c88cac0f

@spichugi Done

Should be FILTER_MAIL

@spichugi Done

It is not what I meant at all...

And the commit header is too long.

It should be something like: Issue: 48851 - Add more search filters to vfilter_simple test suite

rebased onto 34cbfcac6e3fa4326b887e614660469c0990c851

rebased onto 7596ca048c14d4ebcdd77454aa15f272b30482a5

@spichugi Done

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3479

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata