Curious why this is not just on one line? Makes it harder to read IMHO.

Curious why this is not just on one line? Makes it harder to read IMHO.

It is Atom formatter. It uses existing .eslintrc.json file which doesn't have the option for the line length, so the formatter in Atom assumes the default one.

I did set the line length rule in .eslintrc.json before (like 100 or 110) but you removed it.

And I can't find another linter for that... It is really a lot of a code which I don't want to format manually...

Okay, I found a way to make a local line length rule. The indentation is fixed

Automember Plugin & Attribute Uniqueness & Managed Entries & Passthru Auth. Looks like all the plugins do this:

• "Add Config" button too close to table, need top padding/margin

Managed entries

• If click Add Config -> then click Manage --> then click Add I get an odd error from lib389. The modals should have some type of validation, and not send invalid requests to the server. This way you can provide more meaningful errors: "You are missing this require field XXXXXXX", or highlight the border of the input if it is missing, etc.

• In the Add Config modal, what is scope? Perhaps this should be a select dropdown list? The title text for "scope" and "filter" is "broken apart" here.

DNA Plugin

• "Add Config" button is touching table. Needs top padding/margin.
• Control labels in edit/add form are too short and the "text" is word wrapping.
• Odd behavior when I click on "Manage' I get a warning that it will save the entry. After clicking OK it goes to new modal, a empty table. The original modal is also closed, so you can't go back to the original edit/add form. I see what you were you saying about having a hard time trying to lay this all out. It's a bit hard to follow unless you know exactly what you are trying to do. I think this can be improved (maybe even use a wizard), but it can wait for a later release.

Linked Attributes:

• Click on "Link Scope" in empty table crashes browser: error about "onSort" not being a function
• Scope should be dropdown list

Passthru Auth

• Add URL control lables are too short - labels are wrapping. Can be improved for some fields if its widened

Posix Winsync

• Map nested grouping needs title text

Root DN

• Should have titles for each setting

USN Plugin

• Global setting should have title description

Almost all the modals have a "Scope" input that should be a dropdown select list. And again most "Add" buttons are touching the bottoms of tables - they should use "ds-margin-top" css style.

The rest looks good!

The issues are fixed.

Scope fields now have a more detailed description being fields with a base DN value type.
The rest is fixed according to your comments @mreynolds

LGTM

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3455

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.