#50359 Issue: 50358 - Create a Bitwise Plugin class in plugins.py
Closed 3 years ago by spichugi. Opened 4 years ago by aborah.
aborah/389-ds-base plugin  into  master

@@ -2084,3 +2084,16 @@ 

          self.conn.modify_s(dn, [(ldap.MOD_REPLACE,

                                   PLUGIN_PROPNAME_TO_ATTRNAME[PLUGIN_ENABLE],

                                   PLUGINS_ENABLE_OFF_VALUE)])

+ 

+ 

+ class BitwisePlugin(Plugin):

+     """A single instance of Bitwise plugin entry

+ 

+     :param instance: An instance

+     :type instance: lib389.DirSrv

+     :param dn: Entry DN

+     :type dn: str

+     """

+ 

+     def __init__(self, instance, dn="cn=Bitwise Plugin,cn=plugins,cn=config"):

+         super(BitwisePlugin, self).__init__(instance, dn)

Create a Bitwise Plugin class in plugins.py

https://pagure.io/389-ds-base/issue/50358

Author: aborah

Reviewed by: ???

I think there is nothing wrong with this here, but I think for it to have relevance aren't there plugin specific functions you may want to add too for it's configuration?

Never mind, I think it's just enable/disable for this one.

rebased onto aa1bde4

4 years ago

@aborah I did not merge on purpose - sometimes I make mistakes in reviews, and as @spichugi was the one who directed you to create this, I want him to also check to be sure that it's what he is thinking and expecting you to write. (Please also note the lack of ack/lgtm in my comment which is the indication of sign off, meaning I have not approved this code as is.)

Pull-Request has been merged by spichugi

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3418

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata