#50359 Issue: 50358 - Create a Bitwise Plugin class in plugins.py
Closed by spichugi. Opened by aborah.
aborah/389-ds-base plugin  into  master

Download 50359.patch

Create a Bitwise Plugin class in plugins.py

https://pagure.io/389-ds-base/issue/50358

Author: aborah

Reviewed by: ???

I think there is nothing wrong with this here, but I think for it to have relevance aren't there plugin specific functions you may want to add too for it's configuration?

Never mind, I think it's just enable/disable for this one.

rebased onto aa1bde4720781789d5cbe38b7d12c02e0a8c97af

@firstyear , Please merge

@aborah I did not merge on purpose - sometimes I make mistakes in reviews, and as @spichugi was the one who directed you to create this, I want him to also check to be sure that it's what he is thinking and expecting you to write. (Please also note the lack of ack/lgtm in my comment which is the indication of sign off, meaning I have not approved this code as is.)

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3418

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata