#50356 Fix basic test suite on <1.4.1.2
Closed 2 years ago by spichugi. Opened 3 years ago by vashirov.
vashirov/389-ds-base fix-tests-on-rhel7  into  master

@@ -268,7 +268,8 @@ 

      r.import_suffix_from_ldif(ldiffile=import_ldif, suffix=DEFAULT_SUFFIX)

  

      # Good as place as any to quick test the task has some expected attributes

-     assert r.present('nstaskcreated')

+     if ds_is_newer('1.4.1.2'):

+         assert r.present('nstaskcreated')

      assert r.present('nstasklog')

      assert r.present('nstaskcurrentitem')

      assert r.present('nstasktotalitems')
@@ -1149,7 +1150,7 @@ 

          assert conn.searchAuditLog('%s: %s' % (attr, VALUE))

  

  

- @pytest.mark.skipif(not get_user_is_root() or not default_paths.perl_enabled,

+ @pytest.mark.skipif(not get_user_is_root() or not default_paths.perl_enabled or ds_is_older('1.4.0.0'),

                      reason="This test is only required if perl is enabled, and requires root.")

  def test_dscreate(request):

      """Test that dscreate works, we need this for now until setup-ds.pl is

Bug Description:
Tests are failing on <1.4.1.2 where nsTaskCreated attribute doesn't exists

Fix Description:
Check for nsTaskCreated attribute only in 1.4.1.2+
Additionally, run dscreate test only on 1.4.0.0+

https://pagure.io/389-ds-base/issue/50303

Reviewed by: ???

rebased onto e5ae9d0

3 years ago

Pull-Request has been merged by vashirov

3 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3415

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

2 years ago
Metadata