PR#50341: Ticket 50340 - structs for diabled plugins will not be freed - 389-ds-base

389-ds-base

#50341 Ticket 50340 - structs for diabled plugins will not be freed

Closed 3 years ago by spichugi. Opened 4 years ago by lkrispen.

lkrispen/389-ds-base t50340 into master

Ticket 50340 - structs for diabled plugins will not be freed

Ludwig Krispenz • 4 years ago

fc46de6

file modified

		`@@ -779,6 +779,7 @@`
		`if (PR_SUCCESS != PR_CallOnce(&ol_init_callOnce, internal_ol_init_init)) {`
		`slapi_log_err(SLAPI_LOG_ERR, "slapi_ldap_init_ext",`
		`"Could not perform internal ol_init init\n");`
		`+ slapi_ch_free_string(&makeurl);`
		`rc = -1;`
		`goto done;`
		`}`

ldap/servers/slapd/plugin.c

file modified

+1 -1

		`@@ -3040,7 +3040,7 @@`
		`}`

		`PLUGIN_CLEANUP:`
		`- if (status) {`
		`+ if (status \|\| !enabled) {`
		`plugin_free(plugin);`
mreynolds commented 4 years ago This causes a crash when doing an offline db2ldif -r, the plugin is freed and a null pointer is dereferenced
		`}`
		`slapi_ch_free((void **)&configdir);`

lkrispen commented 4 years ago

Bug: when plugins are loaded from dse.ldif enabled plugins will be added to
the list of the plugin type and freed when plugins are stopped.
But the memory allocated for disabled plugins will remain allocated and
and be reported.

Fix: free plugin if not enabled after loading
This will alos let the many leaks reported for "GrowStuff" disappear.
The fix also contains one missing free for slapi_ch_smprintf allocated memory

Reviewed by: ?

mreynolds commented 4 years ago

Ack, can you cherry-pick this to 1.4.0 as well?

rebased onto fc46de6

4 years ago

Pull-Request has been merged by lkrispen

4 years ago

lkrispen commented 4 years ago