389-ds-base

#50324 Fix cockpit console AppStream data
Closed by spichugi. Opened by martinpitt.
martinpitt/389-ds-base cockpit-appstream  into  master

Download 50324.patch
  • Add missing <?xml> header
  • Update to renamed cockpit ID, as "cockpit.desktop" is
    invalid (§ 2.1.3 [1]) and got changed in [2]
  • Avoid dashes in (§2.1.3) and use the actual project's home page.
    Rename the file accordingly.
  • Use a more verbose description from the home page ("style-invalid"
    validation error)
  • Avoid whitespace in
  • Add homepage URL
  • Add

appstream-util validate src/cockpit/389-console/org.cockpit-project.389-console.metainfo.xml
is happy now.

[1] https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
[2] https://github.com/cockpit-project/cockpit/pull/11557

@martinpitt Shouldn't the filename itself match the <id> in it? Or is there a reason not to rename it? Thanks.

rebased onto 3347d922272c0be98978b3660fdf79f6930a0ec8

@mhonek : Good point, I renamed the file.

LGTM!

Pull-Request has been merged by mreynolds

Merged

Thanks @martinpitt !

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3383

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.