use with pytest.raises instead of try except

@firstyear , changes are done , Please check

Why do you add ou: People attribute for the users?

Why do you add ou: People attribute for the users?

There is a dynamic group which has :

group.add("memberURL", f'ldap:///{DEFAULT_SUFFIX}??sub?(&(ou=People)(cn=test_user_1000))')

as by default if you create a user with user = users.create_test_user(uid=i, gid=i)

the dn will be 'uid=test_user_1000,ou=People,dc=example,dc=com' but no ou: 'People'

but dynamic group need ou: 'People '

Why do you add ou: People attribute for the users?

There is a dynamic group which has :
group.add("memberURL", f'ldap:///{DEFAULT_SUFFIX}??sub?(&(ou=People)(cn=test_user_1000))')
as by default if you create a user with user = users.create_test_user(uid=i, gid=i)
the dn will be 'uid=test_user_1000,ou=People,dc=example,dc=com' but no ou: 'People'
but dynamic group need ou: 'People '

It doesn't make sense... We don't create users with ou attribute. If you want to setup memberURL with the specific filter - use something like &(objectclass=person)(cn=test_user_1000))

You can use get() method here. First, create UserAccounts instance (without this rdn). And then get the user by selector (test_user_1000)

@spichugi , changes are done , Please check

It shouldn't be a docstring. It should be a commented text.

Please, go through --pylint output. There are a few issues left

You already have users object. Why not to use it here?

I think it will make more sense if you create a user (and assign it to user for delete operation). And then you can assert if the user is present (user.exists())

I think it will make more sense if you create a user (and assign it to user for delete operation). And then you can assert if the user is present (user.exists())

You cant do it as you only have add privilege to parents .

And UserAccounts(conn, DEFAULT_SUFFIX, rdn='uid=test_user_1000, ou=people') and UserAccounts(topo.standalone, DEFAULT_SUFFIX).get('test_user_1').delete() are different

see conn and topo.standalone

@spichugi , changes are done , Please check

You cant do it as you only have add privilege to parents .
And UserAccounts(conn, DEFAULT_SUFFIX, rdn='uid=test_user_1000, ou=people') and UserAccounts(topo.standalone, DEFAULT_SUFFIX).get('test_user_1').delete() are different

Right. We can't use the same UserAccount instance for the delete operation.
But the rest in my comment is true. assert doesn't make sense here because if the user creation will fail it will through the exception anyway.
We should assert that the user exists().

see conn and topo.standalone !!

The imperative mood plus these two exclamation marks (after a space) can be misunderstood as a rude gesture (it sounds a bit like you are yelling at me).
Please, avoid such expressions in the project.

P.S. I understand that it wasn't, probably, your intention. But to be sure, please, use polite language forms. :)

You cant do it as you only have add privilege to parents .
And UserAccounts(conn, DEFAULT_SUFFIX, rdn='uid=test_user_1000, ou=people') and UserAccounts(topo.standalone, DEFAULT_SUFFIX).get('test_user_1').delete() are different

Right. We can't use the same UserAccount instance for the delete operation.
But the rest in my comment is true. assert doesn't make sense here because if the user creation will fail it will through the exception anyway.
We should assert that the user exists().

see conn and topo.standalone !!

The imperative mood plus these two exclamation marks (after a space) can be misunderstood as a rude gesture (it sounds a bit like you are yelling at me).
Please, avoid such expressions in the project.
P.S. I understand that it wasn't, probably, your intention. But to be sure, please, use polite language forms. :)

Obviously it was not my intention , will keep in mind in future

@spichugi , changes are done , Please check

LGTM! Thanks!
Ack

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3378

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.