RPM build passes basic and sasl tests on F29. :thumbsup:

Please remove the following lines from configure.ac:
# Workaround failure by Mozilla ldapsdk to #include <sasl/sasl.h>
SASL_CFLAGS="$SASL_CFLAGS -I$oldincludedir/sasl"

Then autoreconf -fiv and compile as normal (./configure --enable-debug --with-openldap --enable-cmocka --enable-asan)

These lines should no longer be needed, but it is better to check on a few platforms.

@mreynolds I know you're probably busy, but any time to check this?

@mreynolds I know you're probably busy, but any time to check this?

Sorry this was on my list of things to do today, and.... its done! Works for me, ack!

@hmc I applied your suggested change to @firstyear patch, and it also works for me. So double ack!

@firstyear can you also test @hmc's change?

Which change is that? This is a follow up to @hmc's change to fix thebuild on suse? So I think I have tested it?

Anyway, unless you "scream" in the next few hours, I'll merge it this afternoon, thanks mate :)

Which change is that?

Remove these lines from configure.ac:

# Workaround failure by Mozilla ldapsdk to #include <sasl/sasl.h>
SASL_CFLAGS="$SASL_CFLAGS -I$oldincludedir/sasl"

It would be nice to remove these lines if they are not needed

Sure, I'll remove those, test, and then merge then?

Sure, I'll remove those, test, and then merge then?

:thumbsup:

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3370

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.