389-ds-base

#50309 Ticket 50308 - Fix memory leaks for repeat binds and replication
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket50308  into  master

Download 50309.patch

Description: Fixed two memory leaks:

- If a worker thread had multiple binds the "bind dn"
  thread data was leaked.
- Memory leak when processing changes in the changelog

https://pagure.io/389-ds-base/issue/50308

Reviewed by: ?

Looks pretty reasonable to me, ack

rebased onto 6c2bb66f15d7ab8ab079effc66e0705c2513b1fd

Pull-Request has been merged by mreynolds

Sorry to be late on that review
buf->buf_cscbs[i] was allocated (calloc) few lines above (clcache_new_cscb).
I think we had no leak at this point.

csn_dup_or_init_by_csn does not overwrite the consumer_maxcsn pointer but overwrite the content of it.
I do not see how it can create a leak.

The same here. The content of consumer_maxcsn was overitten but not the pointer.

@tbordaz, ASAN complains about these though :-/ I will double check if they are all needed, but some of them definitely were leaking. I have to fix a compiler warning anyway so I'll see what I can find...

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3368

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.