389-ds-base

#50296 Ticket 49873 - (cont 2nd) Contention on virtual attribute lookup
Closed by spichugi. Opened by tbordaz.
tbordaz/389-ds-base ticket_49873_cont_2  into  master

Download 50296.patch

Bug Description:
SSL initialization does internal searches that access the vattr_global_lock
Thread private counter needs to be initialized by that time.
Currently it is initialized after SSL init.

Fix Description:
Call of vattr_global_lock_create needs to be called before slapd_do_all_nss_ssl_init.
Also, 'main' may or may not fork, the initialization fo the thread private variable
is done either on the child or parent depending if main forks or not.

https://pagure.io/389-ds-base/issue/49873

Reviewed by: ?

Platforms tested: F28

Flag Day: no

Doc impact: no

ack

@mreynolds Thanks for the review, but the fix is not completed yet...
I did not find how to set a flag WIP.

I will push a new patch soon.. sorry for all this noise with this fix

rebased onto 3462b4c36bfafb945ba78d1993339d7acb91c93b

@mreynolds I completed the patch. was fighting with a leak ;)

Tests are passing. Also, the code looks good to me but I'll leave @mreynolds to set ack...

rebased onto aa01206237692c21031481d8ce73654d8ed5da38

@mreynolds I just rebased it. Are you okay with that PR

@mreynolds I just rebased it. Are you okay with that PR

Looks good, but I did not run a COS a test. if you did, then you get my ack!

rebased onto 38d4e5231bebcd03715abec7a67caa33161dc5b0

Thanks @mreynolds , COS tests are successfull

Pull-Request has been merged by tbordaz

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3355

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.