PR#50288: Ticket 49561 - MEP plugin, upon direct op failure, will delete twice the same managed entry - 389-ds-base

389-ds-base

#50288 Ticket 49561 - MEP plugin, upon direct op failure, will delete twice the same managed entry

Closed 3 years ago by spichugi. Opened 5 years ago by tbordaz.

tbordaz/389-ds-base ticket_49561 into master

Ticket 49561 - MEP plugin, upon direct op failure, will delete twice the same managed entry

Thierry Bordaz • 5 years ago

c7da16f

ldap/servers/plugins/mep/mep.c

file modified

+10

		`@@ -2471,6 +2471,11 @@`
		`slapi_log_err(SLAPI_LOG_TRACE, MEP_PLUGIN_SUBSYSTEM,`
		`"--> mep_add_post_op\n");`

		`+ /* Just bail if we aren't ready to service requests yet. */`
		`+ if (!mep_oktodo(pb)) {`
		`+ return SLAPI_PLUGIN_SUCCESS;`
		`+ }`
		`+`
		`/* Reload config if a config entry was added. */`
		`if ((sdn = mep_get_sdn(pb))) {`
		`if (mep_dn_is_config(sdn)) {`
		`@@ -2543,6 +2548,11 @@`
		`slapi_log_err(SLAPI_LOG_TRACE, MEP_PLUGIN_SUBSYSTEM,`
		`"--> mep_del_post_op\n");`

		`+ /* Just bail if we aren't ready to service requests yet. */`
		`+ if (!mep_oktodo(pb)) {`
		`+ return SLAPI_PLUGIN_SUCCESS;`
		`+ }`
		`+`
		`/* Reload config if a config entry was deleted. */`
		`if ((sdn = mep_get_sdn(pb))) {`
		`if (mep_dn_is_config(sdn))`

tbordaz commented 5 years ago

Bug Description:
When a failure occurs during betxn_post plugin callback, the betxn_post plugins are called again.
This is to process some kind of undo action (for example usn or dna that manage counters).

If MEP plugin is called for a managing entry, it deletes the managed entry (that become a tombstone).
If later an other betxn_postop fails, then MEP is called again.
But as it does not detect the operation failure (for DEL and ADD), then it tries again
to delete the managed entry that is already a tombstone.

Fix Description:
The MEP betxn_post plugin callbacks (ADD and DEL) should catch the operation failure
and return.
It is already in place for MODRDN and MOD.

https://pagure.io/389-ds-base/issue/49561

Reviewed by: ?

Platforms tested: F28

Flag Day: no

Doc impact: no