Ack

Bind opens a new connection and bind with the entry.
Also, it doesn't affect your test case because DS instance in lib389 usually is bound as DM.

Besides that moment, the code looks good and the test passes.

@bsmejkal the original push added a test case https://pagure.io/389-ds-base/c/a1578a9bc.

You may prefer to update it than to introduce a new one.

@spichugi Yeah, I knew it is bound as DM by default, I just thought of a case if someone put a test before mine that binds as user and won't rebind as DM, then my test would fail because of insufficient rights. At least this is how I think it works, so please correct me if I am wrong :)

@tbordaz Ah, sorry, I missed this test case. Sure, I will update that one, then.
I see it already searches the logs with helper function because it modifies multiple attributes, so there is propably no need for my use of searchAuditLog()?

@spichugi Yeah, I knew it is bound as DM by default, I just thought of a case if someone put a test before mine that binds as user and won't rebind as DM, then my test would fail because of insufficient rights. At least this is how I think it works, so please correct me if I am wrong :)

Yes, you are right. But the bind you used opens a new connection and binds with the entry.
So you have to use the returned connection in your future operations.

conn = dm.bind()
config_ldbm = LDBMConfig(conn)
assert conn.config.set('nsslapd-auditlog-logging-enabled', 'on')
assert config_ldbm.set('etc')

@tbordaz Ah, sorry, I missed this test case. Sure, I will update that one, then.
I see it already searches the logs with helper function because it modifies multiple attributes, so there is propably no need for my use of searchAuditLog()?

Your use of searchAuditLog is better because it uses lib389 functionality instead of implementing a new one.

Thanks @spichugi this is good feedback :)

@spichugi
Updated the test case with suggested changes, could you please review? Thanks.

LGTM! Thanks!

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3338

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.