#50266 Issue 50263 - LDAPS port not listening after installation
Closed 3 years ago by spichugi. Opened 5 years ago by spichugi.
spichugi/389-ds-base dscr_interactive_start  into  master

@@ -1,5 +1,5 @@ 

  # --- BEGIN COPYRIGHT BLOCK ---

- # Copyright (C) 2016 Red Hat, Inc.

+ # Copyright (C) 2019 Red Hat, Inc.

  # All rights reserved.

  #

  # License: GPL (version 3 or any later version).
@@ -126,7 +126,6 @@ 

          self._type['systemd'] = bool

          self._helptext['systemd'] = "Enables systemd platform features. If set to \"True\", dscreate auto-detects whether systemd is installed. Set this only to \"False\" in a development environment."

  

- 

          self._options['start'] = True

          self._type['start'] = bool

          self._helptext['start'] = "Starts the instance after the install completes. If false, the instance is created but started."

@@ -1,5 +1,5 @@ 

  # --- BEGIN COPYRIGHT BLOCK ---

- # Copyright (C) 2016 Red Hat, Inc.

+ # Copyright (C) 2019 Red Hat, Inc.

  # All rights reserved.

  #

  # License: GPL (version 3 or any later version).

@@ -1,5 +1,5 @@ 

  # --- BEGIN COPYRIGHT BLOCK ---

- # Copyright (C) 2016 Red Hat, Inc.

+ # Copyright (C) 2019 Red Hat, Inc.

  # Copyright (C) 2019 William Brown <william@blackhats.net.au>

  # All rights reserved.

  #
@@ -240,7 +240,7 @@ 

          # Set the defaults

          general = {'config_version': 2, 'full_machine_name': socket.getfqdn(),

                     'strict_host_checking': True, 'selinux': True, 'systemd': ds_paths.with_systemd,

-                    'defaults': '999999999'}

+                    'defaults': '999999999', 'start': True}

  

          slapd = {'self_sign_cert_valid_months': 24,

                   'group': ds_paths.group,
@@ -478,6 +478,19 @@ 

                      else:

                          break

  

+         # Start the instance?

+         while 1:

+             val = input('\nDo you want to start the instance after the installation? [yes]: ').rstrip().lower()

+             if val == '' or val == 'yes' or val == 'y':

+                 # Default behaviour

+                 break

+             elif val == "no" or val == 'n':

+                 general['start'] = False

+                 break

+             else:

+                 print('Invalid value, please use \"yes\" or \"no\"')

+                 continue

+ 

          # Are you ready?

          while 1:

              val = input('\nAre you ready to install? [no]: ').rstrip().lower()

Bug description: When I add an additional instance to my server,
an error is displayed at the end of the installation and
the LDAPS port is not listening.

Fix description: Make interactive installation process
general["start"] argument.

https://pagure.io/389-ds-base/issue/50263

Reviewed by: ?

Seems good from me here too. I'm wondering why the default "start: True" did just apply here though ...

Please, mention in the commit message this is related to the #50202, as in https://pagure.io/389-ds-base/pull-request/50202#_7__59. Thanks.

rebased onto 06b9dd42561886110453602bd37fbcfb4ead2c8b

5 years ago

rebased onto ed530d95bfb1f48c508cce4dc5b7d53035e95829

5 years ago

Seems good from me here too. I'm wondering why the default "start: True" did just apply here though ...

The issue is that the default "start: True" was working okay with the non-interactive install.

But it had failed with the interactive install because general["start"] was not set at all (KeyError while trying to access it).

The commit message was updated. Please, check.

@spichugi Ahhhh I see. Okay, ack from me.

rebased onto 118f8a2

5 years ago

Pull-Request has been merged by spichugi

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3325

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago