Shouldn't it be in DSLdapObjects basedn? (And you are adding it to DSLdapObject - the child)

The rest looks good to me

@spichugi Singulars allow direct initialisation in some cases for DSLdapObject, so in this case where there is only one plugin definition, we pre-set the basedn, allowing you to do:

plugin = SingularPlugin(inst)

@spichugi Singulars allow direct initialisation in some cases for DSLdapObject, so in this case where there is only one plugin definition, we pre-set the basedn, allowing you to do:
plugin = SingularPlugin(inst)

It seems odd to me...

• First, you've set the plugin DN but in case you want to have some default definition - the definition DN should be set ("cn=Example Automember Definition,cn=Auto Membership Plugin,cn=plugins,cn=config").
• Second, the definition should be created anyway (it is not added any place during the instance installation). So the lib389 API user will have their own definitions with the names that are used for their topology. And, I think, it is more explicit do not assume these names for him.
• Third, you've added the feature but you don't use it in your code... Just a small nitpick :)

Ahhhhh I was misreading the patch. I was a bit unwell this morning. So I think your right, the dn= doesn't belong.

What feature did I add? I do use automembership in the code ...

What feature did I add? I do use automembership in the code ...

I was talking about SingularDefinition() object. You've changed the 'dn' part but then you used the MulitpleDefinition() object and SingularDefinition() was not used in your code at all.

But now it doesn't matter. :)

Thank you! PR looks good to me.

I think that was the diff viewer messing with me maybe :) Anyway, fixed now.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3303

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.