I have asked this before, but when adding new types like this you need to provide a test that proves it works.

If they type doesn't use the rdn field, don't include it.

@firstyear all changes are done as per your suggestion

Why do you do this twice instead of:

def = CosClassicDefinitions(...).get('name')
assert def.dn == ...
assert def.get_attr_val_utf8() == ...

Second, you don't really test that the definition is actually working, only that you can create it ... I would think to prove that the definition is created correctly, one needs to test that it actually works correctly within the confines of the plugin.

@firstyear all changes are done as per your suggestion

I think your documentation here is really vague.

ADd comments about what you are doing and why. Just because @aborah of today knows what you are doing, come back in a week and you may forget! I comment everything obsessively because Firstyear of the future is an idiot and needs help.

I don't know why you try to make everything one-liners like this, but it's hard to read and follow. Just please please please use patterns like:

nsc = nsContainer(
    long things
)
nsc.create(...)

OR

nsContainer(
    long things
)
    .create(...)

The former is more "pythonic", the later is "rustic".

@firstyear all changes are done as per your suggestion

You already define "user", above, why not just do "user.present()" ... it's not like the object vanished between then and now ....

@firstyear all changes are done as per your suggestion

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3287

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.