PR#50210: Ticket 49575 - Indicate autosize value errors and corrective actions - 389-ds-base

389-ds-base

#50210 Ticket 49575 - Indicate autosize value errors and corrective actions

Closed 3 years ago by spichugi. Opened 5 years ago by firstyear.

firstyear/389-ds-base 49575-bad-autosize into master

Ticket 49575 - Indicate autosize value errors and corrective actions

William Brown • 5 years ago

00dfb12

file modified

		`@@ -112,6 +112,8 @@`
		`if ((autosize_percentage > 100) \|\| (import_percentage > 100) \|\| (autosize_db_percentage_split > 100) \|\|`
		`((autosize_percentage > 0) && (import_percentage > 0) && (autosize_percentage + import_percentage > 100))) {`
		`slapi_log_err(SLAPI_LOG_CRIT, "ldbm_back_start", "Cache autosizing: bad settings, value or sum of values can not larger than 100.\n");`
		`+ slapi_log_err(SLAPI_LOG_CRIT, "ldbm_back_start", "You should change nsslapd-cache-autosize + nsslapd-import-cache-autosize in dse.ldif to be less than 100.\n");`
		`+ slapi_log_err(SLAPI_LOG_CRIT, "ldbm_back_start", "Reasonable starting values are nsslapd-cache-autosize: 10, nsslapd-import-cache-autosize: -1.\n");`
		`return SLAPI_FAIL_GENERAL;`
		`}`

firstyear commented 5 years ago

Bug Description: The autosize system would fail if the values were
greater than 100 comibined. However, I did not disclose how to fix
these values and where.

Fix Description: Improve the error message to give reasonable
advice and location of the fix for corrective action.

https://pagure.io/389-ds-base/issue/49575

Author: William Brown william@blackhats.net.au

Review by: ???

tbordaz commented 5 years ago

The patch looks good but just a question regarding the recommended nsslapd-cache-autosize value. By default it is 10% and here the message says 20%. Is it because of specific conditions or should we also align default to 20%

firstyear commented 5 years ago

Ahh yes, apparently I was not thinking. I'll make the patch 10%, but I think we should do a review of these values at some point given advances in glibc/our memory management. We may be able to set a larger value now.

rebased onto ef66083fb4749c450d3b10503bda74d442c791ac

5 years ago

firstyear commented 5 years ago

@tbordaz This has been updated :)