#50198 Ticket 50197 - Contain integration improments
Closed by spichugi. Opened by firstyear.
firstyear/389-ds-base 50197-container-integration  into  master

Download 50198.patch

Bug Description: During the container integration process
I have noticed a small number of remaining issues.

Fix Description:
* dm password is left as randomised in container install
* nss_ssl only removes dir content, not the directory itself
* basic tests rely on incorrect assumptions about file perms,
hostnames and ports.

https://pagure.io/389-ds-base/issue/50197

Author: William Brown william@blackhats.net.au

Review by: ???

Small nitpick, a couple of typos...

Probably, the commit subject should be Container integration improvements.

As I've mentioned in another PR:
Port 3636 was already labelled with: (servistaitsm_port_t)

Probably, we can use something like 38901 and 63601 (we use 38900-39299, 63600-63999 ranges in our testing environment)

On reflection, a better idea is just disable the under a variety of circumstances (no systemd, no root).

rebased onto 1f5d66369d44c7e737ab7d387b6a0bdc92f69f8c

The test fails here:

TypeError: 'bool' object is not callable

Besides that, looks good!

rebased onto ff94e562a0c3e10c05fbead70e27215ace47b1d2

Pull-Request has been merged by firstyear

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3257

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata