#50194 Ticket 50165 - Fix issues with dscreate
Closed 2 years ago by spichugi. Opened 3 years ago by mreynolds.
mreynolds/389-ds-base ticket50165  into  master

@@ -32,6 +32,7 @@ 

      assert_c,

      is_a_dn,

      ensure_str,

+     normalizeDN,

      socket_check_open,

      selinux_label_port,

      selinux_restorecon)
@@ -744,7 +745,7 @@ 

          # Create ds_suffix here else it won't be in scope ....

          ds_suffix = ''

          if len(backends) > 0:

-             ds_suffix = backends[0]['nsslapd-suffix']

+             ds_suffix = normalizeDN(backends[0]['nsslapd-suffix'])

  

          # Create certdb in sysconfidir

          self.log.debug("ACTION: Creating certificate database is %s", slapd['cert_dir'])
@@ -856,6 +857,11 @@ 

          # We *ALWAYS* set secure port, even if security is off, because it breaks

          # tests with standalone.enable_tls if we do not. It's only when security; on

          # that we actually start listening on it.

+         if not slapd['secure_port']:

+             if self.containerised:

+                 slapd['secure_port'] = "3636"

+             else:

+                 slapd['secure_port'] = "636"

          ds_instance.config.set('nsslapd-secureport', '%s' % slapd['secure_port'])

          if slapd['self_sign_cert']:

              ds_instance.config.set('nsslapd-security', 'on')

Bug Description: The install would fail under these two conditions:

               [1]  You do not specfiy a secure port, even if not using TLS
               [2]  The suffix has a space after a comma.

Fix Description: If the secure port is not specified set it to the default,
and normalize the suffix DN

https://pagure.io/389-ds-base/issue/50165

Should it also check the containerize option to select 3636 ?

rebased onto a3176c3e52dcbde0cbfe1bf185bf09d71d90bf37

3 years ago

Should it also check the containerize option to select 3636 ?

Probably :-) Done, and rebased, please review again @tbordaz

ACK (probably needs a rebase)

rebased onto 9408b94

3 years ago

Pull-Request has been merged by mreynolds

3 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3253

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

2 years ago
Metadata