#50162 Ticket 50161 - Fixed some descriptions in "dsconf backend --help"
Closed 3 years ago by spichugi. Opened 5 years ago by mmuehlfeldrh.
mmuehlfeldrh/389-ds-base issue_50161  into  master

@@ -595,7 +595,7 @@ 

      #####################################################

      # Suffix parser

      #####################################################

-     suffix_parser = subcommands.add_parser('suffix', help="Manage a backend suffix, including creating backends")

+     suffix_parser = subcommands.add_parser('suffix', help="Manage a backend suffix")

      suffix_subcommands = suffix_parser.add_subparsers(help="action")

  

      # List backends/suffixes
@@ -857,7 +857,7 @@ 

      #######################################################

      # Export LDIF

      #######################################################

-     export_parser = subcommands.add_parser('export', help='do an online export of the suffix')

+     export_parser = subcommands.add_parser('export', help='Do an online export of the suffix')

      export_parser.set_defaults(func=backend_export)

      export_parser.add_argument('be_names', nargs='+',

                                 help="The backend names or the root suffixes from where to export.")
@@ -886,7 +886,7 @@ 

      #######################################################

      # Create a new backend database

      #######################################################

-     create_parser = subcommands.add_parser('create', help='create')

+     create_parser = subcommands.add_parser('create', help='Create a backend database')

      create_parser.set_defaults(func=backend_create)

      create_parser.add_argument('--parent-suffix', default=False,

                                 help="Sets the parent suffix only if this backend is a sub-suffix")
@@ -897,6 +897,6 @@ 

      #######################################################

      # Delete backend

      #######################################################

-     delete_parser = subcommands.add_parser('delete', help='deletes a backend database')

+     delete_parser = subcommands.add_parser('delete', help='Delete a backend database')

      delete_parser.set_defaults(func=backend_delete)

-     delete_parser.add_argument('be_name', help='The backend name or suffix to delete') 

\ No newline at end of file

+     delete_parser.add_argument('be_name', help='The backend name or suffix to delete')

Description: - Help for "suffix" was no longer correct
- Help for "create" changed to "Create a backend database"
- Changed descriptions to start with a capital letter for consistency

https://pagure.io/389-ds-base/issue/50161

Reviewed by: ?

Maybe just drop the 's' in 'Deletes', to conform to imperative form of the rest of the help.

I agree with @mhonek, the "s" should be dropped, but the rest looks good!

rebased onto 8bac1e2

5 years ago

Pull-Request has been merged by mhonek

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3221

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata