PR#50157: Issue 50152 - Replace os.getenv('HOME') with os.path.expanduser - 389-ds-base

389-ds-base

#50157 Issue 50152 - Replace os.getenv('HOME') with os.path.expanduser

Closed 3 years ago by spichugi. Opened 5 years ago by spichugi.

spichugi/389-ds-base home_dir into master

Issue 50152 - Replace os.getenv('HOME') with os.path.expanduser

Simon Pichugin • 5 years ago

ada2dfd

src/lib389/lib389/__init__.py

file modified

+1 -1

		`@@ -778,7 +778,7 @@`

		`# first identify the directories we will scan`
		`sysconfig_head = self.ds_paths.initconfig_dir`
		`- privconfig_head = os.path.join(os.getenv('HOME'), ENV_LOCAL_DIR)`
		`+ privconfig_head = os.path.expanduser(os.path.join('~', ENV_LOCAL_DIR))`
		`if not os.path.isdir(sysconfig_head):`
		`privconfig_head = None`
		`self.log.debug("dir (sys) : %s", sysconfig_head)`

spichugi commented 5 years ago

Description: When HOME env var is not set, the call will fail with an exception.
Instead of HOME we can use expanduser method. The expanduser will do the right thing
and get home directory on all platforms from either env vars or password database.

https://pagure.io/389-ds-base/issue/50152

Reviewed by: ?