#50147 Ticket 50138 - db2bak.pl -P LDAPS does not work when nsslapd-securePort is missing
Closed 3 years ago by spichugi. Opened 5 years ago by mhonek.

@@ -1239,7 +1239,7 @@ 

          $info{host} = $entry->getValues("nsslapd-localhost");

      }

      if($info{port} eq ""){

-         $info{port} = $entry->getValues("nsslapd-port");

+         $info{port} = $entry->getValues("nsslapd-port") || "389";

      }

      if($info{rootdn} eq ""){

          $info{rootdn} = $entry->getValues("nsslapd-rootdn");
@@ -1253,7 +1253,7 @@ 

          $ENV{LDAPTLS_CACERTDIR}=$info{certdir};

      }

      $info{security} = $entry->getValues("nsslapd-security");

-     $info{secure_port} = $entry->getValues("nsslapd-securePort");

+     $info{secure_port} = $entry->getValues("nsslapd-securePort") || "636";

      $info{ldapi} = $entry->getValues("nsslapd-ldapilisten");

      $info{autobind} = $entry->getValues("nsslapd-ldapiautobind");

      $value = $entry->getValues("nsslapd-ldapifilepath");

Bug Description:
When nsslapd-securePort is not set in dse.ldif, DSUtil (in case of LDAPS)
interpolates ldapmodify (and other) call to a URI ending only with a colon
because obtained securePort is just an empty string. The very same turns out to
happen for the nsslapd-port.

Fix Description:
Hardcode the default ports, which is a short variant of omitting the
colon and port, and which would be chosen by the OpenLDAP utils any way.

https://pagure.io/389-ds-base/issue/50138

Author: mhonek

Review by: ???

Well if a port is not provided the default should be assumed, so this makes sense to me. ACK

rebased onto 55045da

5 years ago

Pull-Request has been merged by mhonek

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3206

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago
Metadata