PR#50129: Ticket 50128 - NS Stress fails without ipv6 - 389-ds-base

William Brown • 5 years ago

410d3bb

file modified

+3 -3

		`@@ -352,7 +352,7 @@`
		`PRNetAddr netaddr = {{0}};`
		`char *data = "this is a test!\n";`

		`- sock = PR_OpenTCPSocket(PR_AF_INET6);`
		`+ sock = PR_OpenTCPSocket(PR_AF_INET);`
		`if (sock == NULL) {`
		`char *err = NULL;`
		`PR_GetErrorText(err);`
		`@@ -361,7 +361,7 @@`
		`goto done;`
		`}`

		`- PR_SetNetAddr(PR_IpAddrLoopback, PR_AF_INET6, 12345, &netaddr);`
		`+ PR_SetNetAddr(PR_IpAddrLoopback, PR_AF_INET, 12345, &netaddr);`

		`/* Connect */`
		`/* */`
		`@@ -459,7 +459,7 @@`
		`PRNetAddr netaddr;`
		`PRSocketOptionData prsod = {PR_SockOpt_Nonblocking, {PR_TRUE}};`

		`- PR_SetNetAddr(PR_IpAddrAny, PR_AF_INET6, 12345, &netaddr);`
		`+ PR_SetNetAddr(PR_IpAddrAny, PR_AF_INET, 12345, &netaddr);`

		`listenfd = PR_OpenTCPSocket(PR_NetAddrFamily(&netaddr));`
		`PR_SetSocketOption(listenfd, &prsod);`

Bug Description: Docker for osx doesn't support ipv6, which
means that in ipv4 only environments this test fails.

We aren't trying to test ipv4/ipv6 here, only that NS handles
load, so swapping to ipv4 is not a change to the test

Fix Description: Change the PR_AF_INET6 to PR_AF_INET

Review by: ???

LGTM

rebased onto 410d3bb

5 years ago

Pull-Request has been merged by firstyear

5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3188

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

3 years ago

Assignee

None

Tags

No Tags