#50098 Issue: 48064 - CI test - disk_monitoring
Closed by spichugi. Opened by aborah.
aborah/389-ds-base diskmonitoring  into  master

Download 50098.patch

Bug Description: CI test - disk_monitoring

Fix Description: Scripts are ported

https://pagure.io/389-ds-base/issue/48064

Reviewed by: ???

rebased onto d3c7567c3909c9a9277e8da8f777358faa7701e9

Why do you use classes here? I think the functions will be less confusing here.

it is okay to pass UTF-8 here, not bytes. lib389 does all the magic for you

topo.standalone.config.set('nsslapd-disk-monitoring-grace-period', '1')

please, use subprocess module.
Justification
https://docs.python.org/3/library/subprocess.html#subprocess-replacements

The common practice is to use noun for the fixtures:
smtp_connection, setup, test_user

rebased onto 0cbf6c6baf600685021d1629c95fd0de52db053c

@spichugi all changes are done as suggested by you

rebased onto 1831991e4ac546aaaa4a703b60dd9bddc451c7ba

rebased onto 8ae9b0170f1d0605928659894f15ceb78e0703a1

Please, don't use 'shell=True'. Use a list of arguments like ['dd', 'if=/dev/zero', etc]
Checkout the Warning (red)
https://docs.python.org/2/library/subprocess.html#frequently-used-arguments

One more class here. The same as previous, you don't need it, it can be a function.

these two lines should be put to 'finally' block of 'try-finally'.
We should make sure that the files are deleted even if the test case failed

Always use the open() function in the https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files

with open() as f:
     # do something

It will close the file anyway in the end.

you can get utf8 with get_attr_val_utf8 and compare with a normal string. It is more humany

I think we dont need the sleep here.
It will make the test execution longer for no reason.
You can either verify using a timeout in loop with time.sleep(1) inside (and break from it when the check is successful) or some other way.

topo.standalone.config.set('nsslapd-disk-monitoring', 'on') - this should woek fine (without 'b')

You can add a test user with 'UserAccounts' here instead of legacy Entry object

Please, remove all of the big sleeps (bigger then time.sleep(1)). And use another approach I describe before (or any other way)

Why do you need it? It looks redundant

we have a topo.standalone.config.remove_all() for that in DSLdapObject

rebased onto ccb4b31d18750ad345aa6b55bc3c7eb0b4384e8d

rebased onto 6fa369b788fa62595cb6fffb8d1f1ad83e4bd4cf

@spichugi all changes done . Please merge if all ok .

rebased onto 89ac37f4efc0a758513cf15e07ddc28a269a8b25

rebased onto 1dc6eab1face48825e78cbb838a39bfeb39e9375

Typo :) And this is copied and pasted throughout the script

rebased onto 14890380c5fbc8e07eb68c3e19d99f0a7e2def1e

@mreynolds , typo corrected, :) . Please merge if all ok .

Pull-Request has been merged by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3157

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata