389-ds-base

Clone
Source Code
GIT

#50094 Ticket 50091 - shadowWarning is not generated if passwordWarning is lower than 86400 seconds (1 day)
Closed 3 years ago by spichugi. Opened 5 years ago by tbordaz.
tbordaz/389-ds-base ticket_50091  into  master

file modified
+1 -1 
@@ -3186,7 +3186,7 @@ 
 

              shadowval = _MAX_SHADOW;
 

          }
 

      }
 

-     if (shadowval > 0) {
 

+     if (shadowval >= 0) {
 

          shwarn = slapi_entry_attr_get_charptr(*e, "shadowWarning");
 

          if (shwarn) {
 

              sval = strtoll(shwarn, NULL, 0);

Bug Description:
For a shadowAccount, if a password policy defines passwordWarning below 1 days (86400 seconds)
then the shadowWarning (in day) is not returned from the entry. In such case its value is '0'.

Fix Description:
The fix is to accept shadowWarning = 0 as valid value and return it

https://pagure.io/389-ds-base/issue/50091

Reviewed by: ?

Platforms tested: F27

Flag Day: no

Doc impact: no

LGTM

rebased onto 967d0aa
5 years ago

Pull-Request has been merged by tbordaz
5 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3153

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
3 years ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
ldap/servers/slapd/pw.c
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.