LGTM

Hi, @mreynolds I am observing some regression.
observation:
dirsrvtests/tests/tickets/ticket48325_test.py working in 1.4.0.16-1.fc29 NOT in 1.4.0.19-2.module+el8+1+36e60e1d
dirsrvtests/tests/tickets/ticket49303_test.py working in 1.4.0.18-1.fc28 NOT in 1.4.0.16-1.fc29 OR 1.4.0.19-2.module+el8+1+36e60e1d

I will need to go through the details, what is changed.

What tests are failing in the latest build?

@mreynolds
dirsrvtests/tests/tickets/ticket48325_test.py failing in 1.4.0.19-2.module+el8+1+36e60e1d

dirsrvtests/tests/tickets/ticket49303_test.py failing in both 1.4.0.16-1.fc29 AND 1.4.0.19-2.module+el8+1+36e60e1d

@mreynolds
dirsrvtests/tests/tickets/ticket48325_test.py failing in 1.4.0.19-2.module+el8+1+36e60e1d

This is because we changed the default repl manager DN, please change "cn=replrepl,cn=config" to "cn=replication manager,cn=config"

dirsrvtests/tests/tickets/ticket49303_test.py failing in both 1.4.0.16-1.fc29 AND 1.4.0.19-2.module+el8+1+36e60e1d

This passes for me on F28 using 1.4.0.20

this should be "cn=replication manager,cn=config", also need to update the "cn" value too.

Use "cn=replication manager,cn=config" here too

@mreynolds Changes have been made!

@mreynolds Changes have been made!

Thanks! I'll merge this to master branch

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/3148

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.